test(l2): fetch fee vault addresses from the RPC #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for retrieving the L1 fee vault address dynamically from the L2 RPC server instead of relying on environment variables. The change enables the system to handle optional fee vaults (returning None when not configured) and removes the need for the INTEGRATION_TEST_SKIP_BASE_FEE_VAULT_CHECK environment variable.
- Added new RPC method
ethrex_getL1FeeVaultAddressto retrieve L1 fee vault address - Changed fee vault functions to return
Option<Address>instead ofAddressto support optional vaults - Refactored test code to fetch vault addresses dynamically and skip assertions when vaults are not configured
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/networking/rpc/clients/eth/errors.rs | Added error types for the new L1 fee vault address RPC method |
| crates/l2/networking/rpc/rpc.rs | Registered the new ethrex_getL1FeeVaultAddress RPC method handler |
| crates/l2/networking/rpc/l2/fees.rs | Implemented GetL1FeeVaultAddress handler following existing patterns for fee vault retrieval |
| crates/l2/networking/rpc/clients.rs | Added client function to call the new RPC method and updated return types to Option<Address> |
| crates/l2/tests/tests.rs | Refactored tests to dynamically fetch vault addresses and handle optional vaults, removed hardcoded addresses |
| .github/workflows/pr-main_l2.yaml | Removed INTEGRATION_TEST_SKIP_BASE_FEE_VAULT_CHECK environment variable from CI workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilitteri
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, our integration tests use default
fee vaultaddresses, and to run the tests with custom ones, we need to pass them through env vars.Description
Closes None